Ade Attwood
e121ba7a9f
Summary:
When you are in a project that has files the user cannot read, ivy's finder
will panic will a permission denied error. This can quite easily happen when
using docker on a project, it's quite common to mount a directory into a docker
container that is run as a different user I.E. MySQL. The other example I can
think of is when you are running tests in a container, the test output may be
owned by the containers' user.
When running ivy this is an example of the kind of panic you would get.
```
thread '<unnamed>' panicked at rust/finder.rs:34:41:
called `Result::unwrap()` on an `Err` value: WithPath {
path: "/tmp/workspace/mysql/#innodb_redo", err: Io(
Custom {
kind: PermissionDenied, error: Error {
depth: 2, inner: Io {
path: Some("/tmp/workspace/mysql/#innodb_redo"),
err: Os {
code: 13,
kind: PermissionDenied,
message: "Permission denied"
}
}
}
}
)
}
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
fatal runtime error: Rust panics must be rethrown
```
Ref: #83
Test Plan:
This has been tested locally, right now we don't have any unit tests for this.
We may setup some more testing in the future. This was a little hard to
recreate with out docker and mysql.
43 lines
1.3 KiB
Rust
43 lines
1.3 KiB
Rust
use ignore::{overrides::OverrideBuilder, WalkBuilder};
|
|
use std::fs;
|
|
|
|
pub struct Options {
|
|
pub directory: String,
|
|
}
|
|
|
|
pub fn find_files(options: Options) -> Vec<String> {
|
|
let mut files: Vec<String> = Vec::new();
|
|
let base_path = &fs::canonicalize(options.directory).unwrap();
|
|
|
|
let mut builder = WalkBuilder::new(base_path);
|
|
// Search for hidden files and directories
|
|
builder.hidden(false);
|
|
// Don't require a git repo to use .gitignore files. We want to use the .gitignore files
|
|
// wherever we are
|
|
builder.require_git(false);
|
|
|
|
// TODO(ade): Remove unwraps and find a good way to get the errors into the UI. Currently there
|
|
// is no way to handel errors in the rust library
|
|
let mut override_builder = OverrideBuilder::new("");
|
|
override_builder.add("!.git").unwrap();
|
|
override_builder.add("!.sl").unwrap();
|
|
|
|
let overrides = override_builder.build().unwrap();
|
|
builder.overrides(overrides);
|
|
|
|
for result in builder.build() {
|
|
let absolute_candidate = match result {
|
|
Ok(absolute_candidate) => absolute_candidate,
|
|
Err(..) => continue,
|
|
};
|
|
|
|
let candidate_path = absolute_candidate.path().strip_prefix(base_path).unwrap();
|
|
if candidate_path.is_dir() {
|
|
continue;
|
|
}
|
|
|
|
files.push(candidate_path.to_str().unwrap().to_string());
|
|
}
|
|
|
|
files
|
|
}
|